Skip to content

Updating ContainerStorage Swagger#24749

Merged
rkmanda merged 4 commits intoAzure:mainfrom
aarongalang:cs-july-update
Aug 2, 2023
Merged

Updating ContainerStorage Swagger#24749
rkmanda merged 4 commits intoAzure:mainfrom
aarongalang:cs-july-update

Conversation

@aarongalang
Copy link
Contributor

Updating containerstorage to match Azure-ContainerStorageRP swagger

containerstorage folder should be identical to Swagger/Microsoft.ContainerStorage https://msazure.visualstudio.com/One/_git/Azure-ContainerStorageRP?path=/src/Swagger/Microsoft.ContainerStorage&version=GBmain

Includes:

  • Field Validations

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 10, 2023

Swagger Validation Report

️❌BreakingChange: 33 Errors, 0 Warnings failed [Detail]
compared swaggers (via Oad v0.10.4)] new version base version
containerstorage.json 2023-03-01-preview(d44f25e) 2023-03-01-preview(main)

Only 30 items are listed, please refer to log for more details.

Rule Message
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.ContainerStorage/operations' removed or restructured?
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L56:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.ContainerStorage/pools' removed or restructured?
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L95:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerStorage/pools' removed or restructured?
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L137:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerStorage/pools/{poolName}' removed or restructured?
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L182:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerStorage/pools/{poolName}/volumeSnapshots' removed or restructured?
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L447:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerStorage/pools/{poolName}/volumeSnapshots/{volumeSnapshotName}' removed or restructured?
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L500:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerStorage/pools/{poolName}/volumes' removed or restructured?
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L797:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerStorage/pools/{poolName}/volumes/{volumeName}' removed or restructured?
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L850:5
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'DiskPoolProperties' removed or renamed?
New: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L56:3
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1148:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ElasticSanPoolProperties' removed or renamed?
New: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L56:3
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1148:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ElasticSanPoolPropertiesUpdate' removed or renamed?
New: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L56:3
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1148:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'EphemeralPoolProperties' removed or renamed?
New: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L56:3
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1148:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'EphemeralPoolPropertiesUpdate' removed or renamed?
New: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L56:3
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1148:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'Pool' removed or renamed?
New: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L56:3
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1148:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'PoolProperties' removed or renamed?
New: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L56:3
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1148:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'PoolType' removed or renamed?
New: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L56:3
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1148:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'PoolUpdate' removed or renamed?
New: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L56:3
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1148:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'PoolUpdateProperties' removed or renamed?
New: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L56:3
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1148:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ProvisioningState' removed or renamed?
New: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L56:3
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1148:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ReclaimPolicy' removed or renamed?
New: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L56:3
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1148:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'Volume' removed or renamed?
New: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L56:3
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1148:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'VolumeMode' removed or renamed?
New: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L56:3
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1148:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'VolumeProperties' removed or renamed?
New: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L56:3
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1148:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'VolumeSnapshot' removed or renamed?
New: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L56:3
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1148:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'VolumeSnapshotProperties' removed or renamed?
New: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L56:3
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1148:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'VolumeSnapshotUpdate' removed or renamed?
New: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L56:3
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1148:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'VolumeSnapshotUpdateProperties' removed or renamed?
New: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L56:3
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1148:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'VolumeUpdate' removed or renamed?
New: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L56:3
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1148:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'VolumeUpdateProperties' removed or renamed?
New: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L56:3
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1148:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'systemData' removed or renamed?
New: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L56:3
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1148:3
️⚠️Breaking Change(Cross-Version): 75 Warnings warning [Detail]
compared swaggers (via Oad v0.10.4)] new version base version
containerstorage.json 2023-07-01-preview(d44f25e) 2023-03-01-preview(main)

The following breaking changes are detected by comparison with the latest preview version:

Only 30 items are listed, please refer to log for more details.

Rule Message
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerStorage/pools/{poolName}/volumeSnapshots' removed or restructured?
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L447:5
⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerStorage/pools/{poolName}/volumeSnapshots/{volumeSnapshotName}' removed or restructured?
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L500:5
⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ElasticSanPoolProperties' removed or renamed?
New: Microsoft.ContainerStorage/preview/2023-07-01-preview/containerstorage.json#L1078:3
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1148:3
⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ElasticSanPoolPropertiesUpdate' removed or renamed?
New: Microsoft.ContainerStorage/preview/2023-07-01-preview/containerstorage.json#L1078:3
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1148:3
⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'EphemeralPoolProperties' removed or renamed?
New: Microsoft.ContainerStorage/preview/2023-07-01-preview/containerstorage.json#L1078:3
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1148:3
⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'EphemeralPoolPropertiesUpdate' removed or renamed?
New: Microsoft.ContainerStorage/preview/2023-07-01-preview/containerstorage.json#L1078:3
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1148:3
⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'VolumeMode' removed or renamed?
New: Microsoft.ContainerStorage/preview/2023-07-01-preview/containerstorage.json#L1078:3
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1148:3
⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'VolumeSnapshot' removed or renamed?
New: Microsoft.ContainerStorage/preview/2023-07-01-preview/containerstorage.json#L1078:3
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1148:3
⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'VolumeSnapshotProperties' removed or renamed?
New: Microsoft.ContainerStorage/preview/2023-07-01-preview/containerstorage.json#L1078:3
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1148:3
⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'VolumeSnapshotUpdate' removed or renamed?
New: Microsoft.ContainerStorage/preview/2023-07-01-preview/containerstorage.json#L1078:3
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1148:3
⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'VolumeSnapshotUpdateProperties' removed or renamed?
New: Microsoft.ContainerStorage/preview/2023-07-01-preview/containerstorage.json#L1078:3
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1148:3
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.ContainerStorage/preview/2023-07-01-preview/containerstorage.json#L1480:11
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1558:11
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.ContainerStorage/preview/2023-07-01-preview/containerstorage.json#L1507:11
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1570:11
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.ContainerStorage/preview/2023-07-01-preview/containerstorage.json#L1577:9
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1652:9
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.ContainerStorage/preview/2023-07-01-preview/containerstorage.json#L1584:11
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1671:11
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.ContainerStorage/preview/2023-07-01-preview/containerstorage.json#L1292:11
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1265:11
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: common-types/resource-management/v3/types.json#L175:9
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1795:9
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: common-types/resource-management/v3/types.json#L179:9
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1799:9
⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'Invalid, Ultra' from the old version.
New: common-types/resource-management/v3/types.json#L179:9
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1799:9
⚠️ 1025 - RequiredStatusChange The 'required' status changed from the old version('True') to the new version('False').
New: Microsoft.ContainerStorage/preview/2023-07-01-preview/containerstorage.json#L1465:7
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1545:7
⚠️ 1025 - RequiredStatusChange The 'required' status changed from the old version('True') to the new version('False').
New: common-types/resource-management/v3/types.json#L174:7
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1794:7
⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one 'number'.
New: Microsoft.ContainerStorage/preview/2023-07-01-preview/containerstorage.json#L1492:9
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1551:9
⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one 'string'.
New: Microsoft.ContainerStorage/preview/2023-07-01-preview/containerstorage.json#L1507:11
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1570:11
⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one 'number'.
New: Microsoft.ContainerStorage/preview/2023-07-01-preview/containerstorage.json#L1577:9
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1652:9
⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one 'string'.
New: Microsoft.ContainerStorage/preview/2023-07-01-preview/containerstorage.json#L1584:11
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1671:11
⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one 'string'.
New: Microsoft.ContainerStorage/preview/2023-07-01-preview/containerstorage.json#L1292:11
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1265:11
⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one 'number'.
New: Microsoft.ContainerStorage/preview/2023-07-01-preview/containerstorage.json#L1516:5
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1595:5
⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'poolCapacityGiB' renamed or removed?
New: Microsoft.ContainerStorage/preview/2023-07-01-preview/containerstorage.json#L1465:7
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1545:7
⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'ephemeralPoolProperties' renamed or removed?
New: Microsoft.ContainerStorage/preview/2023-07-01-preview/containerstorage.json#L1465:7
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1545:7
⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'diskPoolProperties' renamed or removed?
New: Microsoft.ContainerStorage/preview/2023-07-01-preview/containerstorage.json#L1465:7
Old: Microsoft.ContainerStorage/preview/2023-03-01-preview/containerstorage.json#L1545:7
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
compared tags (via openapi-validator v2.1.3) new version base version
package-2023-07-01-preview package-2023-07-01-preview(d44f25e) default(main)
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️❌~[NotRequired_Staging] ServiceAPIReadinessTest: 0 Errors, 0 Warnings failed [Detail]

Tag package-2023-07-01-preview; Prod region: Not deployed; Canary region: Not deployed

️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️TypeSpec Validation succeeded [Detail]
Rule Message
InConsistentSwagger "details":"The generated swagger file 2023-07-01-preview/containerstorage.json from typespec specification/containerstorage/ContainerStorage.Management is not the same as the '/mnt/vss/_work/1/azure-rest-api-specs/specification/containerstorage/resource-manager/Microsoft.ContainerStorage/preview/2023-07-01-preview/containerstorage.json' in PR,
please make sure the swagger is consistent with the generated swagger. You can find the difference in the pipeline log."
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-workflow-bot
Copy link

Hi, @aarongalang! Thank you for your pull request. To help get your PR merged:

  • Ensure you reviewed the checklists in the PR description.
  • Know that PR assignee is the person auto-assigned and responsible for your current PR review and approval.
  • For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.
  • @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 10, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking




    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 978acdc. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      warn		specification/containerstorage/ContainerStorage.Management/tspconfig.yaml skipped due to azure-sdk-for-python-track2 not found in tspconfig.yaml
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]  notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.6.7 -> 9.8.1
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.8.1>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.8.1` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-containerstorage [View full logs]  [Release SDK Changes]
      info	[Changelog]   - Initial Release
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 978acdc. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      warn		specification/containerstorage/ContainerStorage.Management/tspconfig.yaml skipped due to azure-sdk-for-python not found in tspconfig.yaml
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh]  New minor version of npm available! 9.6.7 -> 9.8.1
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.8.1>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.8.1` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-containerstorage [View full logs]  [Release SDK Changes]
      info	[Changelog]   - Initial Release
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 978acdc. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      warn		specification/containerstorage/ContainerStorage.Management/tspconfig.yaml skipped due to azure-sdk-for-go not found in tspconfig.yaml
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/containerstorage/armcontainerstorage [View full logs]  [Release SDK Changes]
      info	[Changelog] This is a new package
      info	[Changelog]
    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 978acdc. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️containerstorage [View full logs]  [Release Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 10, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/containerstorage/armcontainerstorage https://apiview.dev/Assemblies/Review/39123ffa4c3f44e5ba4b5fd2559b44a4

    @openapi-workflow-bot
    Copy link

    Hi @aarongalang! The automation detected breaking changes in this pull request. As a result, it added the BreakingChangeReviewRequired label.

    You cannot proceed with merging this PR until you complete one of the following action items:

    ACTION ITEM ALTERNATIVE A: Fix the breaking change.
    Please consult the documentation provided in the relevant validation failures.

    ACTION ITEM ALTERNATIVE B: Request approval.
    Alternatively, if you cannot fix the breaking changes, then you can request an approval for them. Please follow the process described in the High-level Breaking Change Process doc.

    ACTION ITEM ALTERNATIVE C: Report false positive.
    If you think there are no breaking changes, i.e. the validation should pass yet it fails, then proceed as explained in ACTION ITEM ALTERNATIVE B.
    This applies even if the breaking change tool fails with internal runtime error. In such case a manual breaking change review is necessary.

    @openapi-workflow-bot
    Copy link

    Hi @aarongalang! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version.
    For more details refer to the wiki.

    @aarongalang aarongalang force-pushed the cs-july-update branch 8 times, most recently from ec74001 to c8d2f05 Compare July 14, 2023 19:49
    Copy link
    Member

    @mikeharder mikeharder left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Once .npmrc is deleted, you should be able to use the check named "specs - typespec - pr" to know when your spec is fully compliant. You can also run the validation locally using the following command:

    npx tsv specification/containerstorage/ContainerStorage.Management
    

    @Azure Azure deleted a comment from azure-pipelines bot Jul 14, 2023
    @Azure Azure deleted a comment from azure-pipelines bot Jul 14, 2023
    @Azure Azure deleted a comment from azure-pipelines bot Jul 14, 2023
    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 28, 2023
    @croomes
    Copy link

    croomes commented Jul 28, 2023

    I've removed it for @aarongalang

    @aarongalang aarongalang requested a review from visingla-ms July 28, 2023 14:46
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 28, 2023
    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 28, 2023
    @rkmanda rkmanda added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jul 28, 2023
    @visingla-ms visingla-ms added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jul 28, 2023
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 28, 2023
    @mikeharder
    Copy link
    Member

    I've removed it for @aarongalang

    @croomes: Are PR authors supposed to be able to remove the label themselves?

    @aarongalang
    Copy link
    Contributor Author

    How do I fix the Service API Readiness Test?

    @markcowl
    Copy link
    Member

    @aarongalang The Staging checks are not required for check-in, you are currently blocked for needing an approval

    @konrad-jamrozik
    Copy link

    /azp run

    @azure-pipelines
    Copy link

    No commit pushedDate could be found for PR 24749 in repo Azure/azure-rest-api-specs

    @aarongalang
    Copy link
    Contributor Author

    @aarongalang The Staging checks are not required for check-in, you are currently blocked for needing an approval

    Where do I go to ask for approval?

    @konrad-jamrozik
    Copy link

    @aarongalang The Staging checks are not required for check-in, you are currently blocked for needing an approval

    Where do I go to ask for approval?

    Please refer to this diagram:

    Specifically, you need to add the MergeRequested label

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-MissingBaseCommit new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    8 participants