Updating ContainerStorage Swagger#24749
Conversation
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| containerstorage.json | 2023-03-01-preview(d44f25e) | 2023-03-01-preview(main) |
Only 30 items are listed, please refer to log for more details.
️⚠️Breaking Change(Cross-Version): 75 Warnings warning [Detail]
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| containerstorage.json | 2023-07-01-preview(d44f25e) | 2023-03-01-preview(main) |
The following breaking changes are detected by comparison with the latest preview version:
Only 30 items are listed, please refer to log for more details.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
| compared tags (via openapi-validator v2.1.3) | new version | base version |
|---|---|---|
| package-2023-07-01-preview | package-2023-07-01-preview(d44f25e) | default(main) |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️❌~[NotRequired_Staging] ServiceAPIReadinessTest: 0 Errors, 0 Warnings failed [Detail]
Tag package-2023-07-01-preview; Prod region: Not deployed; Canary region: Not deployed
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️TypeSpec Validation succeeded [Detail]
| Rule | Message |
|---|---|
InConsistentSwagger |
"details":"The generated swagger file 2023-07-01-preview/containerstorage.json from typespec specification/containerstorage/ContainerStorage.Management is not the same as the '/mnt/vss/_work/1/azure-rest-api-specs/specification/containerstorage/resource-manager/Microsoft.ContainerStorage/preview/2023-07-01-preview/containerstorage.json' in PR, please make sure the swagger is consistent with the generated swagger. You can find the difference in the pipeline log." |
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
|
Hi, @aarongalang! Thank you for your pull request. To help get your PR merged: Generated ApiView comment added to this PR. You can use ApiView to show API versions diff. |
Swagger Generation Artifacts
|
Generated ApiView
|
ff2dd5b to
c9f17ff
Compare
|
Hi @aarongalang! The automation detected breaking changes in this pull request. As a result, it added the |
|
Hi @aarongalang! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. |
e7b97f0 to
bca2885
Compare
specification/containerstorage/ContainerStorage.Management/package-lock.json
Outdated
Show resolved
Hide resolved
ec74001 to
c8d2f05
Compare
mikeharder
left a comment
There was a problem hiding this comment.
Once .npmrc is deleted, you should be able to use the check named "specs - typespec - pr" to know when your spec is fully compliant. You can also run the validation locally using the following command:
npx tsv specification/containerstorage/ContainerStorage.Management
specification/containerstorage/ContainerStorage.Management/.npmrc
Outdated
Show resolved
Hide resolved
|
I've removed it for @aarongalang |
@croomes: Are PR authors supposed to be able to remove the label themselves? |
|
How do I fix the Service API Readiness Test? |
|
@aarongalang The Staging checks are not required for check-in, you are currently blocked for needing an approval |
|
/azp run |
|
No commit pushedDate could be found for PR 24749 in repo Azure/azure-rest-api-specs |
Where do I go to ask for approval? |
Please refer to this diagram: Specifically, you need to add the |
82bfa7d to
598cc2f
Compare
Updating containerstorage to match Azure-ContainerStorageRP swagger
containerstorage folder should be identical to Swagger/Microsoft.ContainerStorage https://msazure.visualstudio.com/One/_git/Azure-ContainerStorageRP?path=/src/Swagger/Microsoft.ContainerStorage&version=GBmain
Includes: